Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to tox-travis. Fix #246. #248

Merged
merged 9 commits into from
Dec 3, 2019
Merged

Move to tox-travis. Fix #246. #248

merged 9 commits into from
Dec 3, 2019

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Dec 3, 2019

No description provided.

@jezdez jezdez requested a review from pauloxnet December 3, 2019 10:52
@codecov
Copy link

codecov bot commented Dec 3, 2019 •
edited
Loading

Codecov Report

Merging #248 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   90.07%   90.13%   +0.05%     
==========================================
  Files          25       26       +1     
  Lines        1219     1226       +7     
  Branches      106      107       +1     
==========================================
+ Hits         1098     1105       +7     
  Misses         89       89              
  Partials       32       32
Flag Coverage Δ
#coverage ?
#dj111 ?
#dj20 ?
#dj21 ?
#dj22 ?
#dj30 ?
#py27 ?
#py35 ?
#py36 ?
#py37 ?
#py38 ?
#pypy ?
#pypy3 ?
Impacted Files Coverage Δ
configurations/importer.py 85.47% <ø> (ø) ⬆️
configurations/__init__.py 93.33% <100%> (ø) ⬆️
configurations/version.py 100% <100%> (ø)
configurations/base.py 84.12% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12ea3c0...42641f5. Read the comment docs.

@jezdez jezdez mentioned this pull request Dec 3, 2019
Merged
pauloxnet
pauloxnet approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that everything is fine.

@jezdez jezdez merged commit 8d7036d into master Dec 3, 2019
@jezdez jezdez deleted the tox-travis branch December 3, 2019 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jezdez @pauloxnet