Disable network fetch of PCI database by default #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, pcidb was abusing the hosting of the PCIIDS database (see Issue #28). Looks like CI/CD jobs were executing in containers and the container filesystem did not contain the linux host PCIIDS database, causing pcidb to fetch the latest from the pci-ids.ucw.cz website. This PR disables the network fetch behaviour of pcidb by default, which should hopefully address the abusive calls to the pci-ids.ucw.cz hosting service. I'm working separately with @fromani from Red Hat to identify any CI jobs that might have triggered the fetch storm... Signed-off-by: Jay Pipes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, pcidb was abusing the hosting of the PCIIDS database (see
Issue #28). Looks like CI/CD jobs were executing in containers and the
container filesystem did not contain the linux host PCIIDS database,
causing pcidb to fetch the latest from the pci-ids.ucw.cz website.
This PR disables the network fetch behaviour of pcidb by default, which
should hopefully address the abusive calls to the pci-ids.ucw.cz hosting
service.
I'm working separately with @fromanih from Red Hat to identify any CI
jobs that might have triggered the fetch storm...
Signed-off-by: Jay Pipes [email protected]