Fix parsing of PCI domains longer than 4 digits #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Bishop <[email protected]>
jaypipes
reviewed
Sep 4, 2024
pkg/pci/address/address.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
|
|
|||
| var ( | |||
| regexAddress *regexp.Regexp = regexp.MustCompile( | |||
| `^(([0-9a-f]{0,4}):)?([0-9a-f]{2}):([0-9a-f]{2})\.([0-9a-f]{1})$`, | |||
| `^(([0-9a-f]{0,8}):)?([0-9a-f]{2}):([0-9a-f]{2})\.([0-9a-f]{1})$`, | |||
There was a problem hiding this comment.
@ianb-mp OK, so to be fully compliant with the PCI-X spec, I believe this needs to be:
^(1?)(([0-9a-f]{0,4}):)?([0-9a-f]{2}):([0-9a-f]{2})\.([0-9a-f]{1})$
Because, according to my research, the domain part of the PCI address is 4 hexadigits OR a 1 followed by 4 hexadigits (for the cases where the PCI extension configuration space is used)
There was a problem hiding this comment.
ok, I've pushed another commit with that change however moved the 1? inside the existing capture group. I also added a test.
ianb-mp
force-pushed
the
fix_parse
branch
3 times, most recently
from
ccca41a to
e38d615
Compare
Signed-off-by: Ian Bishop <[email protected]>
ianb-mp
added a commit
to ianb-mp/sriov-network-operator
that referenced
this pull request
Sep 5, 2024
See: jaypipes/ghw#373 Signed-off-by: Ian Bishop <[email protected]>
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow parsing of PCI addresses like
10001:80:05.0where the domain component is longer than 4 digits.The domain component should be able to handle values up to 32 bits - see: https://patches.dpdk.org/project/dpdk/patch/[email protected]/
Fixes #372