deps: declare go 1.18 in go.mod #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the go.{mod,sum} files to declare a version of Go that supports
module graph pruning. The change allows consuming projects to avoid picking
up dependencies on modules that ghw only uses for testing or for its CLI.
Fixes jaypipes#328
Signed-off-by: Chris Waldon <[email protected]>
|
thanks for this PR! I'd be happy to approve considering @jaypipes seems already happy with this. |
Signed-off-by: Chris Waldon <[email protected]>
whereswaldon
force-pushed
the
go-1.18
branch
from
059e533 to
d5c8a98
Compare
|
I've attempted to update the Go versions for CI. |
|
Thanks a lot @whereswaldon , looks great! I'm gonna wait a little time to let @jaypipes chime in (e.g. to assess how this change interacts [if at all] with future releases plans, because we're jumping quite a bit of versions), if not I'll merge later considering the past conversation in the issue. Thanks again! |
jaypipes
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the go.{mod,sum} files to declare a version of Go that supports module graph pruning. The change allows consuming projects to avoid picking up dependencies on modules that ghw only uses for testing or for its CLI.
Fixes #328
Signed-off-by: Chris Waldon [email protected]