topology: memory: allow encode/decode cycle (#283) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffromani
force-pushed
the
json-marshal-unmarshal
branch
from
a50c09c to
2ad85e0
Compare
ffromani
force-pushed
the
json-marshal-unmarshal
branch
from
2ad85e0 to
cfff754
Compare
After we fixed jaypipes#275 (allow marshal/unmarshal cycle for block.Info), we discovered few more occourrences which also prevented full JSON encode/decode/encode cycles (aka roundtrips). All of the new findings still see unnecessary limitations, so this patch adds the missing functions. Fixes: jaypipes#283 Signed-off-by: Francesco Romani <[email protected]>
ffromani
force-pushed
the
json-marshal-unmarshal
branch
from
cfff754 to
e3bdbc8
Compare
|
Thanks for working on this so fast |
jaypipes
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we fixed #275 (allow marshal/unmarshal cycle for block.Info),
we discovered few more occourrences which also prevented
full JSON encode/decode/encode cycles (aka roundtrips).
All of the new findings still see unnecessary limitations,
so this patch adds the missing functions.
Fixes: #283
Signed-off-by: Francesco Romani [email protected]