Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDD is classified as SSD on windows 10 #339

Closed
williambrode opened this issue May 1, 2023 · 1 comment · Fixed by #340
Closed

HDD is classified as SSD on windows 10 #339

williambrode opened this issue May 1, 2023 · 1 comment · Fixed by #340
Labels
block Block storage and device issues windows

Comments

@williambrode
Copy link

I was trying out the lib on windows 10 and was surprised to see that it was misclassifying my HDD as an SSD. Turns out the currently logic just says all "fixed" media types are SSD, which is incorrect. The "fixed" media type simply means the disk is internal to the PC, so its not "removable" media for example like a USB drive. I have what I believe to be the correct code (working for me locally) that I will create a PR for.
williambrode added a commit to williambrode/ghw that referenced this issue May 1, 2023
@williambrode
Fix jaypipes#339 by getting the physical disk info which properly sho…
377a471 
…ws SSD vs. HDD.

Signed-off-by: Will Brode <[email protected]>
@jaypipes
Copy link
Owner

jaypipes commented May 2, 2023

Awesome, thanks @williambrode!

@jaypipes jaypipes added windows block Block storage and device issues labels May 2, 2023
@williambrode williambrode mentioned this issue May 2, 2023
Merged
williambrode added a commit to williambrode/ghw that referenced this issue May 2, 2023
@williambrode
Fix jaypipes#339 physical disk media type on windows.
4983158
williambrode added a commit to williambrode/ghw that referenced this issue May 2, 2023
@williambrode
Fix jaypipes#339 - drive media type issue on windows.
9952a87
williambrode added a commit to williambrode/ghw that referenced this issue May 2, 2023
@williambrode
Fix jaypipes#339 - drive media type issue on windows.
2cf6e61 
Signed-off-by: Will Brode <[email protected]>
williambrode added a commit to williambrode/ghw that referenced this issue May 2, 2023
@williambrode
Fix jaypipes#339 - drive media type issue on windows.
7c15197 
Signed-off-by: Will Brode <[email protected]>
jaypipes added a commit that referenced this issue May 4, 2023
@jaypipes
Merge pull request #340 from williambrode/ISSUE-339
3ff88ab 
Fix #339 by getting the physical disk info which properly shows SSD vs HDD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
block Block storage and device issues windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #339 by getting the physical disk info which properly shows SSD vs HDD williambrode/ghw
2 participants
@jaypipes @williambrode