Fix for issues not being marked as resolved #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "resolved" label is not in list of labels created by the system, so that caused that ```python if not affected_systems or severity is None: ``` to have `severity = None`, which basically made it ignore closed issues with no severity status (since you remove the label), after resolving an issue). Now it works as intended. User removes severity label, closes the issue - statuspage generates proper resolved issue in the list.
This was referenced Apr 12, 2017
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 2 2
Lines 316 316
=======================================
Hits 257 257
Misses 59 59
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "resolved" label is not in list of labels created by the system, so that caused
to have
severity = None, which basically made it ignore closed issues with no severity status (since you remove the label), after resolving an issue.Now it works as intended. User removes severity label, closes the issue - statuspage generates proper resolved issue in the list.
This fix also avoids template render error stated in #96