Update webmock for Ruby 2.4.x #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert specs to RSpec 2.99.2 syntax with Transpec
This conversion is done by Transpec 3.3.0 with the following command:
transpec
* 56 conversions
from: obj.should
to: expect(obj).to
* 29 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 3 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 1 conversion
from: == expected
to: eq(expected)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
bump rspec to 3.6
Update RSpec to version 3.6
Bump ruby to use rails 5 minimum 2.2.2
Activesupport is set to all 5.x.x versions Ruby version wasn't actually udpated before, this commit actually updates it to 2.2.2 update gem version roll active support down to 5 for all vers of Rails 5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StubSocketno longer has a#closemethod in Ruby 2.4. Fixed in later versions.