Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out babelrc #23

Merged
merged 2 commits into from
Jun 24, 2017
Merged

Pull out babelrc #23

merged 2 commits into from
Jun 24, 2017

Conversation

zackify
Copy link
Contributor

@zackify zackify commented Jun 23, 2017

This will fix the problem with react native.

@zackify zackify mentioned this pull request Jun 23, 2017
@jaydenseric
Copy link
Owner

Thanks for helping out! Couple of things before merging:

  1. Remove the new .npmignore – we are already specifying files in package.json.
  2. Add a changelog.md entry under a next version heading. Add "Blah blah, fixing [issuelink] via [pullrequestlink]".

@jaydenseric jaydenseric merged commit efcdcd3 into jaydenseric:master Jun 24, 2017
@zackify
Copy link
Contributor Author

zackify commented Jun 24, 2017

Thanks for merging this so fast!!!

@jaydenseric
Copy link
Owner

This is now live in [email protected] – once verified there are no issues with this release we can move out of of beta.

@giautm
Copy link
Contributor

giautm commented Jun 24, 2017

@jaydenseric: I still got problem with babel, i have to install there transformers to make it work. But i'm not sure, because i'm not removed 'node_modules' and try re-install all of modules. The internet at my country temporary down for a time. Give me a day to verify problem. Thanks.

@giautm
Copy link
Contributor

giautm commented Jun 25, 2017

Yeah, it working without install transformers. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants