Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR 2 #4

Open
wants to merge 68 commits into
base: develop
Choose a base branch
from
Open

Dummy PR 2 #4

wants to merge 68 commits into from

Conversation

jayam04
Copy link
Owner

@jayam04 jayam04 commented Jul 21, 2024

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: [Explain here what your PR does and why]
  3. (For bug-fixing PRs only) The original bug occurred because: [Explain what
    the cause of the bug was, and which PR introduced it]

Essential Checklist

Please follow the instructions for making a code change.

  • I have linked the issue that this PR fixes in the "Development" section of the sidebar.
  • I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
  • I have written tests for my code.
  • The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Testing doc (for PRs with Beam jobs that modify production server data)

  • A testing doc has been written: ... (ADD LINK) ...
  • (To be confirmed by the server admin) All jobs in this PR have been verified on a live server, and the PR is safe to merge.

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

gp201 added 30 commits March 11, 2024 20:26
gp201 and others added 29 commits March 24, 2024 19:12
Co-authored-by: U8N WXD <[email protected]>
…n in backend_tests.yml and e2e_lighthouse_performance_acceptance_tests.yml
jayam04 pushed a commit that referenced this pull request Dec 19, 2024
* Managing Issue oppia#20749

* fixed Linter Checks errors

* fixed Linter Checks errors #2

* fixed Linter Checks errors #3

* fixed Linter Checks errors #4

* fixed Linter Checks errors #5

* fixed Linter Checks errors #6

---------

Co-authored-by: Martin Šidlík <[email protected]>
Co-authored-by: Hardik Goyal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants