clean up jax internals in preparation for only allowing hashable values passed as static args #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
force-pushed
the
hashable-static-args-only
branch
from
8c8869c to
0f27abe
Compare
hawkinsp
approved these changes
Jul 14, 2020
mattjj
changed the title
mattjj
force-pushed
the
hashable-static-args-only
branch
from
984f208 to
e51163a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By allowing un-hashable values (wrapping them in a proxy that hashed by identity) we caused too many performance surprises.
This PR doesn't quite impose the requirement that values passed as static arguments to jit be hashable. Instead, this is just preparation: it makes all the fixes in JAX code such that that requirement is satisfied. We still need to fix up some dependents before making the switch.
Related to #3701, #2813, #3708. Once we make the switch, it'll close those first two issues.
See the thread on #4572 for a discussion of how to handle array values as static arguments, even though they're not hashable.