Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled lstsq test due to numerical failures #3054

Merged
merged 1 commit into from
May 12, 2020

Conversation

gnecula
Copy link
Collaborator

@gnecula gnecula commented May 12, 2020

No description provided.

@gnecula
Copy link
Collaborator Author

gnecula commented May 12, 2020

most of the failures can be fixed by adjusting tolerances, but some of the ones involving complex numbers deserve more scrutiny:

https://test.corp.google.com/ui#id=OCL:311065922:BASE:311067170:1589263694968:629eb55a

@gnecula gnecula requested a review from jakevdp May 12, 2020 07:05
@gnecula gnecula merged commit cc9de87 into jax-ml:master May 12, 2020
@gnecula gnecula deleted the copybara4 branch May 12, 2020 07:06
@gnecula
Copy link
Collaborator Author

gnecula commented May 12, 2020

Relates to #2744

j-towns pushed a commit to j-towns/jax that referenced this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants