-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pivoted QR on GPU via MAGMA. #25955
base: main
Are you sure you want to change the base?
Conversation
47dc68d
to
ac4aeb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've approved so that we can run all the tests, but also left some small inline comments.
The TPU failures are unrelated, but can you rebase onto the current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work on this. I think we're there! One tiny last comment. Then can you rebase onto main
(there's a merge conflict with the CHANGELOG)? Then, I can merge. Thanks again!
MAGMA 2.9.0 was released yesterday and now supports a workspace query for Would you prefer I update this pull to make a workspace query and require |
Let's leave this as is! So, we're getting quite a few JVP failures in |
I can reproduce these errors. I'm pretty sure I've implemented the pivot inversion in |
Originally noted in jax-ml#20282, this commit provides a GPU compatible implementation of `geqp3` via MAGMA.
Originally noted in #20282, this commit provides a GPU compatible implementation of
geqp3
via MAGMA.MAGMA implementation is based on @dfm's implementation of
eig
in ccb3317.Maybe closes #12897?
To reduce code duplication I've moved
AllocateWorkspace
fromsolver_kernels_ffi.cc
intoffi_helpers.h
.