Cleanup: toward merging core.concrete_aval & xla.abstractify #25456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
force-pushed
the
xla-abstractify
branch
2 times, most recently
from
fd24bf9 to
2b7dbc5
Compare
jakevdp
changed the title
jakevdp
force-pushed
the
xla-abstractify
branch
from
e39fff6 to
2c722d9
Compare
dougalm
approved these changes
Dec 17, 2024
google-ml-butler
bot
added
kokoro:force-run
pull ready
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to merge
core.concrete_avalwithxla.abstractify. The two functions are quite similar, but differ slightly in the details. In particular,core.concrete_avalincludes sharding information whilexla.abstractifydoes not. Additionally,xla.abstractifyis in the dispatch path, and therefore is more optimized in some cases.This first change simply moves
xla.abstractifytocore.abstractify, and moves the implementation of the two functions to the same locations so that they're easier to compare. This PR does not change any of the rule registrations; I plan to do that in a followup in order to localize potentially breaking and/or performance-sensitive changes.