[NVIDIA] Adjust the atol/rtol of JAX SDPA API tests #24427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbodenstein @superbobry Could you take a look and approve if it looks good to you? This issue is blocking our CI tests, so it would be helpful if it could be merged soon. |
superbobry
approved these changes
Oct 22, 2024
|
@superbobry Thanks for approving. Is that anything else we can do to unblock the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, our CI encountered a mismatch issue on Ampere GPUs, which turned out to be a tolerance issue. So, we are taking this opportunity to adjust the atol and rtol values in the tests. This PR includes those changes.
Initially, I included this adjustment in #24352, but now I think it might be better to submit it as a separate PR instead.