[pallas] Disallow capturing of consts by kernel functions #22746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
pallas_consts
branch
3 times, most recently
from
f06be19 to
fc15da8
Compare
superbobry
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Does it make sense to also drop const hoisting from run_state, since we are moving towards making pallas_call a wrapper around run_state?
CC @sharadmv
Previously this was allowed, but until recently (jax-ml#22550) it was not working correctly in many cases. Now we disallow const capturing because it can lead to surprises. Instead, the kernel function must receive all the arrays it needs as explicit inputs, with proper block specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was allowed, but until recently (#22550) it was
not working correctly in many cases. Now we disallow const
capturing because it can lead to surprises. Instead, the
kernel function must receive all the arrays it needs as explicit
inputs, with proper block specs.