[WIP ]Implementation of np.linalg.lstsq #2200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @shoyer can you take a look at this? |
|
Right now the error is in typechecking, int64 vs int32 and the same for floats, can you point me towards a way to fix this please? |
IvanYashchuk
suggested changes
Mar 19, 2020
Co-Authored-By: Ivan Yashchuk <[email protected]>
|
Ok, so after explicit casting and @IvanYashchuk help, tests are passing @shoyer |
|
Hey @mattjj Can you check this out please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1999
Make sure the implementation works when rank = m = n and when rank = m != n
Write tests