Add ffi_call function with a similar signature to pure_callback.
#21743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_641313727
branch
3 times, most recently
from
d7e427b to
b935a54
Compare
This could be useful for supporting the most common use cases for FFI custom calls. It has several benefits over using the `Primitive` based approach, but the biggest one (in my opinion) is that it doesn't require interacting with `mlir` at all. It does have the limitation that transforms would need to be registered using interfaces like `custom_vjp`, but many users of custom calls already do that. ~~The easiest to-do item (I think) is to implement batching using a `vectorized` parameter like `pure_callback`, but we could also think about more sophisticated vmapping interfaces in the future.~~ Done. The more difficult to-do is to think about how to support sharding, and we might actually want to expose an interface similar to the one from `custom_partitioning`. I have less experience with this part so I'll have to think some more about it, and feedback would be appreciated! PiperOrigin-RevId: 641313727
copybara-service
bot
force-pushed
the
test_641313727
branch
from
b935a54 to
99d8d62
Compare
|
Closing in favor of #21925 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ffi_callfunction with a similar signature topure_callback.This could be useful for supporting the most common use cases for FFI custom
calls. It has several benefits over using the
Primitivebased approach, butthe biggest one (in my opinion) is that it doesn't require interacting with
mlirat all. It does have the limitation that transforms would need to beregistered using interfaces like
custom_vjp, but many users of custom callsalready do that.
The easiest to-do item (I think) is to implement batching using a
Done.vectorizedparameter likepure_callback, but we could also think about moresophisticated vmapping interfaces in the future.
The more difficult to-do is to think about how to support sharding, and we
might actually want to expose an interface similar to the one from
custom_partitioning. I have less experience with this part so I'll have tothink some more about it, and feedback would be appreciated!