Deprecate non-array inputs to jnp.array_equal & jnp.array_equiv #18708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
force-pushed
the
array-equal-dep
branch
from
c9c238b
to
43cb68a
Compare
jakevdp
force-pushed
the
array-equal-dep
branch
from
43cb68a
to
13dd5e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7737. Fixes #14901 and #17621
I opted not to go the
check_arraylikeroute, because there are many downstream uses ofjnp.arrays_equalon tuple/list inputs. Instead, we just deprecate the case where inputs cannot be coerced to an array, which is the most confusing case.