jax.numpy indexing: lower to dynamic_slice for more cases #15377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
added a commit
to jakevdp/jax
that referenced
this pull request
Apr 4, 2023
This will allow checkify tests to continue working properly after jax-ml#15377
jakevdp
added a commit
to jakevdp/jax
that referenced
this pull request
Apr 4, 2023
This will allow checkify tests to continue working properly after jax-ml#15377
jakevdp
force-pushed
the
gather-slice
branch
3 times, most recently
from
f7042d2 to
a963919
Compare
jakevdp
force-pushed
the
gather-slice
branch
4 times, most recently
from
46d8c7f to
3eac0c0
Compare
yashk2810
reviewed
Apr 6, 2023
yashk2810
approved these changes
Apr 6, 2023
jakevdp
force-pushed
the
gather-slice
branch
9 times, most recently
from
fee1bae to
4c0e44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #15390 in order for checkify tests to continue to pass
Replaces #15347, which used static slices.