in closure_convert, hoist all tracers involved in staging
#14760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjj
approved these changes
Mar 2, 2023
froystig
force-pushed
the
closure-convert-hoist-everything
branch
from
cdf14a7 to
b43e6e7
Compare
froystig
force-pushed
the
closure-convert-hoist-everything
branch
2 times, most recently
from
10d9a3c to
ddc1a5b
Compare
froystig
force-pushed
the
closure-convert-hoist-everything
branch
2 times, most recently
from
a1b6bc6 to
904cd9d
Compare
We need to hoist all `DynamicJaxprTracer`s in `jax.closure_convert`,
not only those that are float-dtyped. Leaving any `DynamicJaxprTracer`
in the closure of a `custom_{jvp,vjp}`'ed function might result in a
tracer leak, as staging to jaxpr could already be complete by the time
the closure is consumed.
Co-authored-by: Matthew Johnson <[email protected]>
froystig
force-pushed
the
closure-convert-hoist-everything
branch
from
904cd9d to
0e6fea4
Compare
|
We can't quite merge this because it breaks this test: Skimming discussion #9951 to which it links, the approach we'd intend going forward is to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with @mattjj
We need to hoist all
DynamicJaxprTracers injax.closure_convert, not only those that are float-dtyped. Leaving anyDynamicJaxprTracerin the closure of acustom_{jvp,vjp}'ed function might result in a tracer leak, as staging to jaxpr could already be complete by the time the closure is consumed.