Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove static argnums from random.fold_in #1039

Merged
merged 1 commit into from
Jul 23, 2019
Merged

remove static argnums from random.fold_in #1039

merged 1 commit into from
Jul 23, 2019

Conversation

pzhokhov
Copy link
Contributor

No description provided.

@pzhokhov
Copy link
Contributor Author

fixes #1033. According to discussion there, have not changed the docstring yet.

@mattjj mattjj mentioned this pull request Jul 23, 2019
Closed
mattjj
mattjj approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@mattjj mattjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

As mentioned on #1033, this currently causes a subtle change in behavior when data is a 64bit Python int or ndarray scalar, in that it will now be cast down to 32bit first. See the linked comment for more info.

@mattjj mattjj merged commit 915dc60 into jax-ml:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjj mattjj mattjj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzhokhov @mattjj @googlebot