Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 Bump version to 2.0.4 #72

Merged
merged 8 commits into from
Jul 30, 2021
Merged

🔖 Bump version to 2.0.4 #72

merged 8 commits into from
Jul 30, 2021

Conversation

Ousret
Copy link
Member

@Ousret Ousret commented Jul 23, 2021

Changes:

@Ousret Ousret added the bugfix release Minor release for bug fixes label Jul 23, 2021
@Ousret Ousret changed the title 🔖 Bump version to 2.0.4 🔖 Bump version to 2.0.4 Jul 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #72 (2a4fd59) into master (8247f3a) will decrease coverage by 0.78%.
The diff coverage is 85.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   85.50%   84.71%   -0.79%     
==========================================
  Files          11       11              
  Lines        1083     1145      +62     
==========================================
+ Hits          926      970      +44     
- Misses        157      175      +18     
Impacted Files Coverage Δ
charset_normalizer/utils.py 77.40% <80.00%> (-1.02%) ⬇️
charset_normalizer/md.py 88.19% <91.17%> (-0.42%) ⬇️
charset_normalizer/api.py 82.05% <100.00%> (-2.06%) ⬇️
charset_normalizer/cli/normalizer.py 64.83% <100.00%> (ø)
charset_normalizer/models.py 87.11% <100.00%> (ø)
charset_normalizer/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8247f3a...2a4fd59. Read the comment docs.

@Ousret
Copy link
Member Author

Ousret commented Jul 30, 2021

The dataset was updated to include more files.

See

The README will be updated accordingly to new results.

(Using GHA)

------------------------------
--> Chardet Conclusions
   --> Avg: 0.1948392037470726s
   --> 99th: 0.87039s
   --> 95th: 0.34092s
   --> 50th: 0.0313s
------------------------------
--> Charset-Normalizer Conclusions
   --> Avg: 0.05083911007025761s
   --> 99th: 0.49343s
   --> 95th: 0.26959s
   --> 50th: 0.02116s

(Using my local computer)

------------------------------
--> Chardet Conclusions
   --> Avg: 0.15073866510538642s
   --> 99th: 0.64759s
   --> 95th: 0.25023s
   --> 50th: 0.02402s
------------------------------
--> Charset-Normalizer Conclusions
   --> Avg: 0.0363623887587822s
   --> 99th: 0.35432s
   --> 95th: 0.20218s
   --> 50th: 0.01601s

@Ousret
Copy link
Member Author

Ousret commented Jul 30, 2021

The diff coverage is acceptable (84.71% (-0.79%)).
Will be addressed in another PR.

@Ousret Ousret merged commit 558d1e2 into master Jul 30, 2021
@Ousret Ousret deleted the v2.0.4 branch July 30, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix release Minor release for bug fixes
Development

Successfully merging this pull request may close these issues.

2 participants