Give helpful hint if sampling frequency isn't prime #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but do you mind separating it in one PR per feature, perhaps one for the primes, one for the new argument, etc? |
src/main.rs
Outdated
| @@ -105,6 +105,9 @@ struct Cli { | |||
| /// Output file for Flame Graph in SVG format | |||
| #[arg(long, default_value = "flame.svg")] | |||
| flamegraph_file: PathBuf, | |||
| /// Enable eBPF debug output | |||
| #[arg(long, action=ArgAction::SetFalse)] | |||
There was a problem hiding this comment.
nit: this is not the BPF logs but the libbpf ones
Sure thing - I've reverted that change in this branch - we probably need to discuss it anyway, as in BPF vs libbpf logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we exit with error if the
--sample-freqoption is provided with a non-prime number.This prevents accidentally sampling at rates that could collide with other system events more easily, leading to unintended feedback.
But, it doesn't help the user know what numbers they should have picked.
This PR adjusts the error message to include the prime numbers below and above the sampling rate that was requested.