Improve handling of deleted executable object files #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As before this commit, if lightswitch finds an object file that's been deleted, which are named as `$original_name (deleted)` we would return an error and never add the unwind information for any of the object files. We could see this for example in lightswitch as I assume some parts of the runtime could load the debuginfo file at runtime and then remove it at some point. This commit also slighly improves the code/ Test Plan ========= Ran while running another `lightswitch` instance, the error is not showing up anymore.
javierhonduco
deleted the
improve-handling-of-deleted-executable-object-files
branch
javierhonduco
added a commit
that referenced
this pull request
Sep 16, 2024
As before this commit, if lightswitch finds an object file that's been deleted, which are named as `$original_name (deleted)` we would return an error and never add the unwind information for any of the object files. We could see this for example in lightswitch as I assume some parts of the runtime could load the debuginfo file at runtime and then remove it at some point. This commit also slighly improves the code/ Test Plan ========= Ran while running another `lightswitch` instance, the error is not showing up anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As before this commit, if lightswitch finds an object file that's been deleted, which are named as
$original_name (deleted)we would return an error and never add the unwind information for any of the object files. We could see this for example in lightswitch as I assume some parts of the runtime could load the debuginfo file at runtime and then remove it at some point.This commit also slighly improves the code/
Test Plan
Ran while running another
lightswitchinstance, the error is not showing up anymore.