Run test in CI #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierhonduco
force-pushed
the
run-test-in-ci
branch
from
f01b84c to
1ac6a6b
Compare
We were not running tests in ci, so fix this, also add a step just to enter the nix dev environment so the we know how long does it take to pull / build our native dependencies and tooling. Also changing `check` -> `build` as the CLI integration tests require the debug binary to be built. This is a bit janky and we should have better integration with the build system. We'll change this later on. Test Plan ========= ci :)
javierhonduco
force-pushed
the
run-test-in-ci
branch
from
1ac6a6b to
2108a46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not running tests in ci, so fix this, also add a step just to
enter the nix dev environment so the we know how long does it take to
pull / build our native dependencies and tooling.
Also changing
check->buildas the CLI integration tests requirethe debug binary to be built. This is a bit janky and we should have
better integration with the build system. We'll change this later on.
Test Plan
ci :)