Use crossbeam_channel and stop profiling on control+c
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `crossbeam_channel` crate offers a couple of nice features that the standard library producer/comsumer channel doesn't have, including a `select!` macro that lets us poll from the first available channel when we are polling from several channels. This commit reworks this logic to unify everything using this macro, resulting in potential fewer waits in the worst case scenario and cleaner logic. This work started to add support for SIGINT aka control+c handling, which is included in this commit. Once the signal is received, profiling will stop and the profile will be dealt with as soon as the channels are polled again. Test Plan ========= Interrupted profiling with control+C without any issues, made sure it works for short and long durations to verify there are no regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crossbeam_channelcrate offers a couple of nice features that the standard library producer/comsumer channel doesn't have, including aselect!macro that lets us poll from the first available channel when we are polling from several channels. This commit reworks this logic to unify everything using this macro, resulting in potential fewer waits in the worst case scenario and cleaner logic.This work started to add support for SIGINT aka control+c handling, which is included in this commit. Once the signal is received, profiling will stop and the profile will be dealt with as soon as the channels are polled again.
Test Plan
Interrupted profiling with control+C without any issues, made sure it works for short and long durations to verify there are no regressions.