-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow eBPF map sizes and general buffer size for profiler to be changed via CLI options #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierhonduco
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a comment about the value_is_power_of_two
separation, if you could do it I think it would be nicer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several CLI options to set defaults for and allow modifying the size of most eBPF maps and the perf buffer for the profiler:
--mapsize-info
prints the eBPF map sizes after they've been created--mapsize-stacks
to adjust max number of individual stacks to capture before they are aggregated--mapsize-aggregated-stacks
to adjust the max number of unique stacks to be stored after aggregation from the stacks map--mapsize-unwind-info-chunks
to adjust the max number of chunks allowed to be in a single shard--mapsize-unwind-tables
to adjust the max number of shards allowed--mapsize-rate-limits
to adjust when to impose rate limits on incoming profiling data--perf-buffer-bytes
to adjust the size of each profiler perf bufferAlso added a config validator for
--perf-buffer-bytes
, as the value must be a power of 2.Added tests for the validator function.