Add integration tests #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with C++ binaries. This work leverages the nix build system to build the test programs [0] and executes them while running the profiler to ensure the traces are what we expect. There are some future improvements such as testing other languages and programs, as well as asserting metadata, and improving the assertion helper to ensure that the frames are correct by changing it to be a macro and not converting it to a string Test Plan ========= Added tests, CI [0]: https://github.com/javierhonduco/lightswitch-testprogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with C++ binaries. This work leverages the nix build system to build the test programs 0 and executes them while running the profiler to ensure the traces are what we expect.
There are some future improvements such as testing other languages and programs, as well as asserting metadata, and improving the assertion helper to ensure that the frames are correct by changing it to be a macro and not converting it to a string
Test Plan
Added tests, CI