Implement unwind information reset #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implmementation has several shortcomings, and doesn't have any rate-limiting in place. We will continue to improve this and have plans to revisit how we store chunks (as this can be optimized) as well as how the unwind information is laid out to try to prevent expensive state resets. Test Plan ========= Ran on busy hosts that used all shards. The state was resest and profiling continued as usual.
|
cc @gmarler as this should fix the bug you reported. Let me know if that's not the case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implmementation has several shortcomings, and doesn't have any rate-limiting in place. We will continue to improve this and have plans to revisit how we store chunks (as this can be optimized) as well as how the unwind information is laid out to try to prevent expensive state resets.
Test Plan
Ran on busy hosts that used all shards. The state was resest and profiling continued as usual.