Improve main executable detection #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic here is a bit flimsy and should be reworked, but let's at least mark first executables as the "main" ones. More context in the comment but overall this is not always correct, in particular Rust + static musl is broken due how the loader operates for that case. We should understand the kernel and loader's logic in detail and fully replicate it here. Test Plan ========= Ran locally for several minutes without issues. The profilers looked good (see PR) and 0 unexpected errors were emitted.
|
cc @gmarler. I will spend some time when I have the cycles improving this because it's not 100% correct in some situations, I don't think this is standardized anywhere so reading the kernel / loader sources might be the only way to do this properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here is a bit flimsy and should be reworked, but let's at least mark first executables as the "main" ones.
More context in the comment but overall this is not always correct, in particular Rust + static musl is broken due how the loader operates for that case.
We should understand the kernel and loader's logic in detail and fully replicate it here.
Test Plan
Ran locally for several minutes without issues. The profilers looked good (see PR) and 0 unexpected errors were emitted.