Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Read debug info in streaming / chunks #138

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

javierhonduco
Copy link
Owner

Rather than allocating space to store it all in memory. This was done like this before as during prototyping I did not know if reqwest would also do this or stream the file.

I've since memory profiled reqwest and checked its source code and it doesn't keep the whole body in memory.

Test Plan

Manually checked that it continues to work and that the file is read in chunks with a memory profiler (heaptrack).

Rather than allocating space to store it all in memory. This was done
like this before as during prototyping I did not know if reqwest would
also do this or stream the file.

I've since memory profiled reqwest and checked its source code and it
doesn't keep the whole body in memory.

Test Plan
=========

Manually checked that it continues to work and that the file is read in
chunks with a memory profiler (heaptrack).
@javierhonduco javierhonduco merged commit 209d31e into main Jan 16, 2025
4 checks passed
@javierhonduco javierhonduco deleted the read-debug-info-in-chunks branch January 16, 2025 14:59
@javierhonduco javierhonduco mentioned this pull request Jan 22, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant