Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unwind info manager implementation and use it #129

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add unwind info manager implementation and use it #129

merged 1 commit into from
Jan 15, 2025
+300 −34

Conversation

javierhonduco
Copy link
Owner

@javierhonduco javierhonduco commented Jan 8, 2025 •
edited
Loading

  • Add unwind info manager implementation
  • Use unwind information manager

@javierhonduco javierhonduco changed the title Persist unwind info 2 Add unwind info manager implementation and use it Jan 8, 2025
@javierhonduco javierhonduco requested a review from rdelfin January 8, 2025 16:23
javierhonduco
javierhonduco commented Jan 8, 2025
View reviewed changes
src/unwind_info/persist.rs Show resolved Hide resolved
src/unwind_info/persist.rs Show resolved Hide resolved
@javierhonduco javierhonduco force-pushed the persist-unwind-info-2 branch 4 times, most recently from 76ccff5 to 62ec8b8 Compare January 13, 2025 13:39
@javierhonduco javierhonduco marked this pull request as ready for review January 13, 2025 13:39
@javierhonduco javierhonduco force-pushed the persist-unwind-info-2 branch 3 times, most recently from 3eb2a53 to d42bac2 Compare January 13, 2025 16:57
rdelfin
rdelfin reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@rdelfin rdelfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a few questions before approving?

src/profiler.rs Outdated Show resolved Hide resolved
src/profiler.rs Outdated Show resolved Hide resolved
src/unwind_info/manager.rs Show resolved Hide resolved
src/unwind_info/manager.rs Show resolved Hide resolved
src/unwind_info/manager.rs Show resolved Hide resolved
@rdelfin
Copy link
Collaborator

rdelfin commented Jan 13, 2025

(discussed offline, happy for it to merge once the comments aboved are addressed

@javierhonduco
Add unwind info manager implementation
7e94279 
That acts as a transparent disk cache for unwind information.

Test Plan
=========

Added tests + and manual tests
@javierhonduco javierhonduco merged commit 466503a into main Jan 15, 2025
4 checks passed
@javierhonduco javierhonduco deleted the persist-unwind-info-2 branch January 15, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdelfin rdelfin rdelfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierhonduco @rdelfin