object: Improve correctness #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierhonduco
force-pushed
the
object-correctness-improvements
branch
from
33390b0 to
1887e3f
Compare
rdelfin
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Co-authored-by: Ricardo Delfin [email protected]
Some truly slanderous statements
Just a couple comments
javierhonduco
force-pushed
the
object-correctness-improvements
branch
from
1887e3f to
f294e2b
Compare
Due to the fact that `object::File` takes a reference to the mmap-ed file, we needed to do some awful lifetime hacks to fit it in the API we wanted. While getting rid of the raw pointer and drop impl, Ricardo noticed that there was some lurking UB too, so this fixes it as well. Co-authored-by: Ricardo Delfin <[email protected]> Test Plan ========= CI
javierhonduco
force-pushed
the
object-correctness-improvements
branch
from
f294e2b to
29d5970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
object: Improve correctness
Due to the fact that
object::Filetakes a reference to the mmap-edfile, we needed to do some awful lifetime hacks to fit it in the API we
wanted. While getting rid of the raw pointer and drop impl, Ricardo
noticed that there was some lurking UB too, so this fixes it as well.
Co-authored-by: Ricardo Delfin [email protected]
Test Plan
CI