Skip to content

Commit

Permalink
Reduce unwind table size
Browse files Browse the repository at this point in the history
This drops the unwind table size from 250k entries to 100k as RHEL 8
seems to be having issues with larger maps. We aren't sure if this will
fix the issue but will continue investigating and will adjust this
accordingly.
  • Loading branch information
javierhonduco committed Apr 19, 2024
1 parent 889d7ce commit cb42431
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/bpf/profiler.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "basic_types.h"

#define MAX_UNWIND_INFO_SHARDS 25
#define MAX_UNWIND_INFO_SHARDS 65

// Number of frames to walk per tail call iteration.
#define MAX_STACK_DEPTH_PER_PROGRAM 7
Expand All @@ -20,8 +20,8 @@ _Static_assert(MAX_TAIL_CALLS *MAX_STACK_DEPTH_PER_PROGRAM >= MAX_STACK_DEPTH,
// 2^19 can bisect ~524_288 entries.
#define MAX_BINARY_SEARCH_DEPTH 19
// Size of the unwind table.
// 250k * sizeof(stack_unwind_row_t) = 2MB
#define MAX_UNWIND_TABLE_SIZE 250 * 1000
// 100k * sizeof(stack_unwind_row_t) = 1.4MB
#define MAX_UNWIND_TABLE_SIZE 100 * 1000
_Static_assert(1 << MAX_BINARY_SEARCH_DEPTH >= MAX_UNWIND_TABLE_SIZE,
"unwind table is big enough");

Expand Down

0 comments on commit cb42431

Please sign in to comment.