Merge pull request #335 from wojtekmaj/no-is-core-module

Remove `is-core-module` dependency

package.json

@@ -35,7 +35,6 @@
     "chalk": "4.1.2",
     "eslint-import-resolver-node": "0.3.9",
     "eslint-module-utils": "2.8.1",
-    "is-core-module": "2.13.1",
     "micromatch": "4.0.5"
   },
   "devDependencies": {

src/core/elementsInfo.js

@@ -1,4 +1,4 @@
-const isCoreModule = require("is-core-module");
+const mod = require("module");
 const micromatch = require("micromatch");
 const resolve = require("eslint-module-utils/resolve").default;
 
@@ -9,6 +9,14 @@ const { isArray } = require("../helpers/utils");
 
 const { filesCache, importsCache, elementsCache } = require("./cache");
 
+function isCoreModule(moduleName) {
+  const moduleNameWithoutPrefix = moduleName.startsWith("node:")
+    ? moduleName.slice(5)
+    : moduleName;
+
+  return mod.builtinModules.includes(moduleNameWithoutPrefix);
+}
+
 function baseModule(name) {
   if (isScoped(name)) {
     const [scope, packageName] = name.split("/");

test/rules/one-level/element-types.spec.js

@@ -166,6 +166,18 @@ const test = (settings, options, errorMessages) => {
           },
         ],
       },
+      // Can import fs module
+      {
+        filename: absoluteFilePath("modules/module-a/ModuleA.js"),
+        code: "import fs from 'fs'",
+        options,
+      },
+      // Can import node:fs module
+      {
+        filename: absoluteFilePath("modules/module-a/ModuleA.js"),
+        code: "import fs from 'node:fs'",
+        options,
+      },
     ],
     invalid: [
       // Helpers can't import another if everything is disallowed