Add failing string concat tests (Java 11) #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisTestUser
changed the title
Closed
|
Thank you for the tests. I will merge the PR but have realized that GitHub actions were not yet set up for this branch. I'll do that first, and I hope I can run this PR on the CI setup retroactively (perhaps it has to be closed and re-opened?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string concatenation tests involving toString(), which currrently fail in Java 11, as the object itself is passed into StringConcatFactory.makeConcatWithConstants() during the invokedynamic call. This issue was described in #258.