Server/ClientProtocolHandler: override isSharable() to get rid of unn…

…ecessary reflection, thread locals and wasted memory.
jauntsdn · May 24, 2024 · f7f19c3 · f7f19c3
1 parent 5fc287a
commit f7f19c3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java b/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java
@@ -93,6 +93,11 @@ public ChannelFuture handshakeCompleted() {
     return completed;
   }
 
+  @Override
+  public boolean isSharable() {
+    return false;
+  }
+
   @Override
   public void handlerAdded(ChannelHandlerContext ctx) {
     handshakeCompleted = ctx.newPromise();

diff --git a/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java b/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketServerProtocolHandler.java
@@ -87,6 +87,11 @@ public ChannelFuture handshakeCompleted() {
     return completed;
   }
 
+  @Override
+  public boolean isSharable() {
+    return false;
+  }
+
   @Override
   public void handlerAdded(ChannelHandlerContext ctx) {
     handshakeCompleted = ctx.newPromise();