WebSocketClientProtocolHandler: make default allowMaskMismatch = true

jauntsdn · Feb 9, 2023 · e3dca48 · e3dca48
1 parent bebd5c5
commit e3dca48
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/...c/test/java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketValidationTest.java b/...c/test/java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketValidationTest.java
@@ -60,6 +60,28 @@ void tearDown() throws Exception {
     }
   }
 
+  @Test
+  void serverBuilderMinimalConfigIsValid() {
+    WebSocketServerProtocolHandler serverProtocolHandler =
+        WebSocketServerProtocolHandler.create()
+            .webSocketCallbacksHandler(
+                (ctx, webSocketFrameFactory) -> {
+                  throw new AssertionError("never called");
+                })
+            .build();
+  }
+
+  @Test
+  void clientBuilderMinimalConfigIsValid() {
+    WebSocketClientProtocolHandler clientProtocolHandler =
+        WebSocketClientProtocolHandler.create()
+            .webSocketHandler(
+                (ctx, webSocketFrameFactory) -> {
+                  throw new AssertionError("never called");
+                })
+            .build();
+  }
+
   @Timeout(15)
   @Test
   void frameSizeLimit() throws Exception {

diff --git a/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java b/...java/com/jauntsdn/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.java
@@ -246,7 +246,7 @@ public static final class Builder {
     private String subprotocol;
     private HttpHeaders headers;
     private boolean mask = true;
-    private boolean allowMaskMismatch;
+    private boolean allowMaskMismatch = true;
     private int maxFramePayloadLength = 65_535;
     private long handshakeTimeoutMillis = 15_000;
     private WebSocketCallbacksHandler webSocketHandler;