-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
37bbaae
to
c88282c
Compare
Performance concerns with cljfmt completely mitigated as of weavejester/cljfmt#58. Formatting limitations (or at least differences with the many varied styles within core) remain so this is by no means a complete fixup despite high LoC impact. Among unsupported features are |
c88282c
to
8d9e7b0
Compare
Will take a look at this, I think the formatting could be a little more optimal. Probably best to do it all in one fell swoop. |
|
2b35c0a
to
4e7b729
Compare
Remaining concerns:
|
Honestly dinking with this more is making me more inclined to just merge this since it provides a low bar for lisp formatting, and we can raise that bar incrementally rather than trying to do a monolithic reformat. In part because it feels like doing this 'right' involves writing an official style guide up front, which I don't feel is a great use of time. |
e7ee2ed
to
5b66e7b
Compare
Yeah after more dinking I'm really not convinced that this is worth the up front effort of imposing more code style than cljfmt can automate. Unless there is opposition to the point, I'll just fix the build and merge this tomorrow. Would it be nice if one interop style were preferred yes. Would it be nice if metadata notation were consistent yes. Is it worth my time to rewrite all of core by hand one fn at a time... probably not since what's there works. |
f6cde1a
to
c44fc68
Compare
This changeset adds cljfmt as a linter, checking both the Clojure sources and the Clojure tests. It's not perfect, but it's better than nothing.
Also reformats both sources sets so that the linter runs cleanly.
Fixes #31