This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
Var metadata contracts #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this works, and works well. The only real question is under what conditions should Vars emit warnings that their options/state are changing. Right now only |
arrdem
force-pushed
the
feature/42
branch
6 times, most recently
from
2681f88
to
340c397
Compare
Just a quick wrapper for generating the increasingly used file/line/column string.
This patch makes Var impement the metadata parts of AReference itself,
so that changes to metadata can be observed. This allows Var to update
the internal status flags corresponding to isPublic, isDynamic, isMacro
etc.
This deals with a class of state errors wherein the metadata of the Var
would not correctly reflect the state of the Var. For instance, since
privacy was decoupled from ^:private, it was possible for a Var to
become `{:private true}` and be .isPrivate() -> False, and vice versa.
Furthermore this patch causes Var to emit warnings when a Var looses its
^:dynamic, ^:once or ^:private bits. This helps capture a class of user
metadata update errors where the Var's metadata is simply reset.
Fixes #42
This patch deals with one instance of the Var metadata state loss bugs. *agent* is dynamic, has a tag and metadata. Previously, its metadata was altered in RT with .resetMeta(), which lost the ^:dynamic flag. This patch fixes that bug, and moves the metadata and tag initialization of *agent* into core since it doesn't need to be in RT at all.
This patch again fixes metadata updating issues. So that tests can alter it to access basic printing, print-initialized is supposed to be private and dynamic. It is initially false valued, but is eventually redefined to be true once Clojure's printing has been initialized. This patch fixes the way that print-initialized is redefined so that pertinent metadata is not lost.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset implements #42 and provides both Var metadata property
caching (
^:dynamic,^:privateetc.) and correct cache updating whenmetada changes.
As a consequence of this change, it becomes necessary to patch core so
that it correctly manages Var state changes.