This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
Revert deprecation of *clojure-version*, clojure-version #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't a good reason why *clojure-version* is deprecated. It's still entirely meaningful, and there are a bunch of Clojure libraries which inspect this value to determine behavior which leads to pointless warnings since libraries are not expected to target Jaunt at this point.
By the same argument given previously about *clojure-version*
arrdem
force-pushed
the
revert/deprecate-clj-version
branch
from
1ad754d to
a5d56d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These symbols still have perfectly reasonable meanings in the context of Jaunt, and their deprecation means that a bunch of junk warnings may be generated.