This repository has been archived by the owner on Jan 28, 2019. It is now read-only.
Single arity deprecation support #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds compiler support for `^:deprecated` metadata on single function arities. When compiling with deprecation warnings, static invocations analyzing to deprecated arities will generate appropriate warnings. This is implemented using a simple linear scan arglist matcher which supports variable arities and could in future be extended for typed invocation matching.
arrdem
force-pushed
the
feature/deprecated-arities
branch
from
18c07b6
to
aaaaf00
Compare
arrdem
force-pushed
the
feature/deprecated-arities
branch
from
dc39f39
to
7e0eed8
Compare
arrdem
force-pushed
the
feature/deprecated-arities
branch
from
7e0eed8
to
1b94d04
Compare
| @@ -3205,7 +3205,7 @@ public static Expr parse(Var v, ISeq args, Object tag) { | |||
| java.lang.reflect.Method[] allmethods = c.getMethods(); | |||
|
|
|||
| IPersistentVector theargs = null; | |||
| if(arglists != null) { | |||
| if (arglists != null) { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134