Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method for unregister broadcast receiver #13

Merged
merged 5 commits into from
Sep 26, 2019

Conversation

iamatulkumar
Copy link
Contributor

Resolved #12

Copy link
Owner

@jaumard jaumard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution !
Just few minor things to change but that good for me.
Can you add something on the Readme as everybody should called unregister on their dispose

example/ios/Flutter/flutter_export_environment.sh Outdated Show resolved Hide resolved
example/lib/main.dart Outdated Show resolved Hide resolved
Copy link
Owner

@jaumard jaumard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing a call to unregisterReceiver()
2 participants