Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Versions #82

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Update Python Versions #82

merged 6 commits into from
Mar 27, 2024

Conversation

jatkinson1000
Copy link
Owner

Closes #71

  • Raises minimum python version to 3.10 as discussed in Bump to Python 3.10 #71
  • Also adds testing using latest python 3.12 and uses 3.12 for linting/coverage
  • Updates github workflows to latest versions

Checklist:

  • Source code updated to address issue
  • Style and formatting applied
  • Tests written to cover changes
  • Docstrings included/updated in code
  • Project documentation updated as necessary

@jatkinson1000 jatkinson1000 self-assigned this Mar 6, 2024
This was referenced Mar 6, 2024
@jatkinson1000
Copy link
Owner Author

@TomHall2020 I think this is ready to be merged if you fancy casting an eye?
It updates a number of the 3.10 things that came up during your recent PRs.

@jatkinson1000 jatkinson1000 added the documentation Improvements or additions to documentation label Mar 23, 2024
@jatkinson1000 jatkinson1000 mentioned this pull request Mar 23, 2024
5 tasks
Copy link
Contributor

@TomHall2020 TomHall2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good, there's the option to clean up some of the type hinting syntax but that isn't necessary and depends a bit on taste anyway, plus theres always more stuff coming in future versions.

archeryutils/classifications/agb_indoor_classifications.py Outdated Show resolved Hide resolved
archeryutils/handicaps/handicap_scheme.py Show resolved Hide resolved
archeryutils/handicaps/handicap_scheme.py Show resolved Hide resolved
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.64%. Comparing base (347e105) to head (f3c830a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files          28       28           
  Lines        1611     1613    +2     
=======================================
+ Hits         1573     1575    +2     
  Misses         38       38           
Files Coverage Δ
...utils/classifications/agb_field_classifications.py 100.00% <100.00%> (ø)
...tils/classifications/agb_indoor_classifications.py 100.00% <100.00%> (ø)
.../classifications/agb_old_indoor_classifications.py 100.00% <100.00%> (ø)
archeryutils/handicaps/handicap_scheme.py 96.98% <ø> (ø)
archeryutils/targets.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@jatkinson1000 jatkinson1000 merged commit 758d235 into main Mar 27, 2024
12 checks passed
@jatkinson1000 jatkinson1000 deleted the python-versions branch March 27, 2024 12:22
jatkinson1000 added a commit that referenced this pull request May 6, 2024
* Update python minimum to 3.10 in pyproject.toml.

* Add notes to README and docs to detail minimum python version as 3.10

* Update workflows to use 3.10 as minimum python version, add 3.12 as latest, and update actions to latest versions.

* Fix linting issue (use strict in zip) that arises with minimum version being 3.10.

* Update to explicit TypeAlias in targets, with note thqat this is deprecated in favour of  in python 3.12+.
jatkinson1000 added a commit that referenced this pull request Jun 8, 2024
* Update Python Versions (#82)

* Update python minimum to 3.10 in pyproject.toml.

* Add notes to README and docs to detail minimum python version as 3.10

* Update workflows to use 3.10 as minimum python version, add 3.12 as latest, and update actions to latest versions.

* Fix linting issue (use strict in zip) that arises with minimum version being 3.10.

* Update to explicit TypeAlias in targets, with note thqat this is deprecated in favour of  in python 3.12+.

* Update ready for PyPI upload.

* Set version to 1.0.0

* Update License to use real name instead of GitHub username.

* Update README with badges.

* Fix location specifier for a local install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to Python 3.10
2 participants