-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifications refactor #42
Conversation
Sorry, I'm not really sure what behaviour you're trying to retain. Please could you post example snippets of how you'd like things to work and how things have to work instead due to this PR? |
Basically I want it to work the same as previously, so I tried to make it so that I could have all of the functions in these files wrapped up into |
I think I've figured it out. In your top-level from archeryutils.classifications import classifications So when you import import archeryutils.classifications as classifications |
M8 that's done it. |
fb7b1cd
to
dec4db8
Compare
Adding classification tests so that this PR will also close #23 |
classifications.
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
===========================================
+ Coverage 71.47% 90.03% +18.56%
===========================================
Files 11 21 +10
Lines 936 1114 +178
===========================================
+ Hits 669 1003 +334
+ Misses 267 111 -156
|
Closes #39
Consider also tackling #24Refactor excessively long classifications file into several separate ones for each type of classification (plus general utils file).
It would be nice for the code to continue functioning as it previously did with
rather than having to import each type of classification (indoor, outdoor, etc.) separately.
I have made an effort to do this using the classifications module
__init__.py
but it's not quite working.@LiamPattinson is there any chance you could cast an eye and advise me what is best to do?
This could also be related to issue #3
TODO: