Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New indoor classifications. #34

Merged
merged 13 commits into from
Aug 14, 2023
Merged

New indoor classifications. #34

merged 13 commits into from
Aug 14, 2023

Conversation

jatkinson1000
Copy link
Owner

@jatkinson1000 jatkinson1000 commented Jun 17, 2023

Will close #33

  • Deprecate current indoor functions
  • Update json data files to have indoor and outdoor data
    • Update existing classification functions to use new parameters for outdoors
  • Implement new indoor classification structure
    • start with dict formed identical as outdoor
      • update ages to be a functions Decided unnecessary. Changed datum and classification steps.
      • Investigate new parameters
    • Get classification and scores needs to:
      • Handle trad/flatbow/asiatic
      • handle [X] triple faces and [X] compound scoring
        • WA
        • Portsmouth
        • Stafford
        • Others
  • Xs on Worcester and Vegas? - May be separate issue... Won't be done here, decided not necessary for indoors.

@jatkinson1000 jatkinson1000 added the enhancement New feature or request label Jun 17, 2023
@jatkinson1000 jatkinson1000 self-assigned this Jun 17, 2023
@jatkinson1000
Copy link
Owner Author

jatkinson1000 commented Aug 2, 2023

New indoor functions created that use same thresholds as outdoors for now.
Use of full face is enforced.
Handling of maximum scores is done by checking next integer handicap.
Parameters for indoor and outdoor as in json (though currently identical).

Still to do:

  • Enforce compound scoring for compounds?
    Already handled by archerycalculator. Consider raising an error or returning unclassified if passed the inappropriate round?
  • Changing parameters and how they vary for different categories.
  • Xs? Not required for this now, so perhaps make a future feature.

@jatkinson1000
Copy link
Owner Author

Now enforce compound scoring for indoor classifications.
Updated numbers for indoor classifications following meeting.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #34 (a3bc864) into main (be83325) will decrease coverage by 3.34%.
Report is 2 commits behind head on main.
The diff coverage is 43.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   74.88%   71.55%   -3.34%     
==========================================
  Files          11       11              
  Lines         848      935      +87     
==========================================
+ Hits          635      669      +34     
- Misses        213      266      +53     
Files Changed Coverage Δ
archeryutils/classifications/classifications.py 50.86% <43.43%> (-3.96%) ⬇️

@jatkinson1000 jatkinson1000 merged commit e0a7ee0 into main Aug 14, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New indoor classifications
1 participant