Skip to content
This repository has been archived by the owner on Jul 7, 2019. It is now read-only.

Added german translation. (de_DE) #4

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Added german translation. (de_DE) #4

merged 1 commit into from
Nov 3, 2016

Conversation

Pandiora
Copy link
Contributor

@Pandiora Pandiora commented Nov 3, 2016

No description provided.

@Pandiora Pandiora mentioned this pull request Nov 3, 2016
@jaszhix jaszhix merged commit f5fdc36 into jaszhix:master Nov 3, 2016
@jaszhix
Copy link
Owner

jaszhix commented Nov 3, 2016

Nice work. I had to rename the file to de.po because that's the name of the system locale.

@Pandiora
Copy link
Contributor Author

Pandiora commented Nov 3, 2016

Hm, I was sure de_DE should be the right locale-convention and it works for me. But however, maybe this way de_AT and de_CH is also supported. FFS, "Hover Peek"-Translation got removed again, I'm creating another PR.

@dscso
Copy link

dscso commented Nov 3, 2016

To say something of topic: As far as I know is the German of Austria etc. not that different from German of Germany, if you are talking about such things.

@Pandiora
Copy link
Contributor Author

Pandiora commented Nov 3, 2016

@dscso Thats right, but in Swiss they're just partially speaking german. And this is the point where it makes sense to have multiple languages for one country and why you have the convention "language_COUNTRY". Swiss isn't the best example here because even if they speak French there, this person would use French as System-Language and this way would use the fr.po. (if I understand correctly how the language-detection /-selection works)

@jaszhix
Copy link
Owner

jaszhix commented Nov 3, 2016

I renamed it because I saw this error:

cp: cannot create regular file '/home/jason/.local/share/locale/de_DE/LC_MESSAGES/[email protected]': No such file or directory

@dscso
Copy link

dscso commented Nov 3, 2016

@Pandiora: yes... This lang_country is just because there exist different accents in the different countries...

@Pandiora
Copy link
Contributor Author

Pandiora commented Nov 3, 2016

@jaszhix I will create another PR to pull it into the right folder.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants