Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for NULL pointer in jp2_decode #197

Closed
wants to merge 1 commit into from
Closed

Check for NULL pointer in jp2_decode #197

wants to merge 1 commit into from

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Mar 15, 2019

@theta682
Copy link
Contributor

theta682 commented Mar 18, 2019 •
edited
Loading

This fix breaks loading of some correct files. It checks incorrect place for NULL-pointer. Function jp2_getct returns interger not a pointer. Correct fix would be to check for incorrect MTYP values in CMAP box. The problematic code does not initialize dec->chantocmptlut[channo] which is used to index dec->image->cmpts_ array.

@theta682 theta682 mentioned this pull request Mar 18, 2019
Closed
@jubalh
Copy link
Member Author

jubalh commented Mar 21, 2019

@theta682 I agree!

Tested your patch against the valid file you uploaded and against a reproducer file. Your patch is better. Do you have any more of them for the other CVEs? ;-)

Closing this in favour of #200

@jubalh jubalh closed this Mar 21, 2019
@jubalh jubalh mentioned this pull request Jul 3, 2019
Closed
jubalh pushed a commit to jasper-maint/jasper that referenced this pull request Jun 19, 2020
@theta682 @jubalh
Fix CVE-2018-19542: Check for NULL pointer in jp2_decode
ade4b48 
Patch by Timothy Lyanguzov <[email protected]>
originally proposed at jasper-software/jasper#200.

To fix jasper-software/jasper#182.
Instead of jasper-software/jasper#197 /
https://gist.github.com/apoleon/701d7db34d63faa16463935b1465c74e.

Fix #7
@jubalh jubalh mentioned this pull request Jun 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubalh @theta682