More accurate heartbeat timing #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So logging occurs even if notify fails.
|
This has been updated to work on Python 3 correctly |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original heartbeat thread was prone to missing heartbeat sends due to the accuracy of the sleep timing. This modification calculates the sleep time based on when the next event is required, instead of being a fixed time. An example of the old code missing sleeps is here:
2016-03-07 14:34:30 stomp.py INFO Sending frame cmd='STOMP' headers={'passcode': 'xxx', 'login': 'xxx', 'accept-version': '1.1', 'heart-beat': '10000,0'}
2016-03-07 14:34:40 stomp.py INFO Sending frame cmd=None headers={}
2016-03-07 14:34:50 stomp.py INFO Sending frame cmd=None headers={}
2016-03-07 14:35:00 stomp.py INFO Sending frame cmd=None headers={}
2016-03-07 14:35:10 stomp.py INFO Sending frame cmd=None headers={}
2016-03-07 14:35:30 stomp.py INFO Sending frame cmd=None headers={}
2016-03-07 14:35:50 stomp.py INFO Sending frame cmd=None headers={}
Additionally there is a cleanup of the heartbeat thread reference so that the thread is properly restarted if we reconnect following a timeout.